Open
Conversation
…uppressing warnings across supported compilers a bit more clean. Obviously it's better if we don't suppress warnings at all, but for where we do, we can at least make the code around that look less bad.
… if we're not gonna use the result.
…ing supressions while I'm there.
mkoscumb
added
OTEL
mkoscumb
requested review from
bliptec,
kindbe,
lalitb,
larvacea,
maxgolov and
reyang
as code owners
mkoscumb
changed the title
Contributor
|
@mkoscumb, could you please resolve the conflicts in this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm super tired of writing giant ifdef blobs to properly push/disable/pop compiler warnings. This makes things a bit easier and - ideally - more readable when we do need to suppress a warning. Intentionally not converting warnings to macros in modules (yet), public headers (as I want to avoid collision with consumers), and third party code.
I'm not wild about macros, but this is one of the times where they're warranted.